feat(runtime): execute canonical agent specs in deterministic dry-run - #6
feat(runtime): execute canonical agent specs in deterministic dry-run#6ProfRandom92 wants to merge 6 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds agent-related commands (validate-spec, dry-run, and replay) to the CLI, introducing new modules for contract definitions and agent execution logic, alongside a security check to block access to sensitive directories. The feedback highlights several critical improvements: preventing a potential panic when replaying empty evidence logs, using case-insensitive comparisons to avoid security bypasses on case-insensitive file systems, buffering file writes to improve performance, and caching compiled regular expressions using OnceLock.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@coderabbitai full review |
…ufWriter, and static regex
…urity_paths_rejected
1 participant
Objective
Execute canonical agent specs in deterministic dry-run and replay validation within the Rust runtime CLI.
Security & Quality Hardening
.git,.ssh, and.awsusingeq_ignore_ascii_case().actual_events.last()access inhandle_agent_replayto use panic-safe pattern matching.std::io::BufWriterwith explicitflush().^[a-z][a-z0-9_-]*$usingstd::sync::OnceLock.Tests & Quality Gates
cargo test --all-targets): 42 unit tests insrc/main.rs&src/cli_p1.rs, 84 integration tests intests/cli_smoke.rs.cargo fmt --all --check: Passed cleanly.cargo clippy --all-targets -- -D warnings: Passed cleanly with 0 warnings.